Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RHINENG-10032: implement pg_repack job and admin API #1475

Merged
merged 6 commits into from
Sep 12, 2024

Conversation

Dugowitch
Copy link
Contributor

@Dugowitch Dugowitch commented Sep 6, 2024

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

Copy link

jira-linking bot commented Sep 6, 2024

Referenced Jiras:
https://issues.redhat.com/browse/RHINENG-10032

@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.06%. Comparing base (ebaa313) to head (812cde5).
Report is 16 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1475      +/-   ##
==========================================
+ Coverage   65.01%   65.06%   +0.04%     
==========================================
  Files         114      114              
  Lines        7823     7877      +54     
==========================================
+ Hits         5086     5125      +39     
- Misses       2207     2215       +8     
- Partials      530      537       +7     
Flag Coverage Δ
unittests 65.06% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dugowitch Dugowitch marked this pull request as ready for review September 6, 2024 14:07
psegedy
psegedy previously requested changes Sep 6, 2024
database_admin/migrations/129_create_pg_repack.up.sql Outdated Show resolved Hide resolved
tasks/repack/repack.go Show resolved Hide resolved
tasks/repack/repack.go Outdated Show resolved Hide resolved
manager/routes/routes.go Outdated Show resolved Hide resolved
Copy link
Member

@psegedy psegedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@psegedy psegedy merged commit 34a6037 into RedHatInsights:master Sep 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants